[smart_holder] Dummy change. Just to trigger CI. #5175

rwgk · 2024-06-19T17:27:39Z

Description

Dummy change. Just to trigger CI (similar to #3939 for master).

Suggested changelog entry:

rwgk · 2024-06-19T18:03:37Z

Re failures for:

3 • Clang dev • C++11 • x64

Last succeeding:

https://github.com/pybind/pybind11/actions/runs/9473989000/job/26102731866

Tue, 11 Jun 2024 23:12:01 GMT

C++ Info: Debian Clang 19.0.0 (++20240514105158+3ca428c09062-1~exp1~20240514225211.712)

First failing:

https://github.com/pybind/pybind11/actions/runs/9586053423/job/26433234621?pr=5175

Wed, 19 Jun 2024 17:28:01 GMT

From log on master (using #3939):

C++ Info: Debian Clang 19.0.0 (++20240619112312+5dde4951ae16-1~exp1~20240619112324.785)

rwgk · 2024-06-19T18:05:40Z

Copy of error message:

For easy reference, this is the clang version:

C++ Info: Debian Clang 19.0.0 (++20240619112312+5dde4951ae16-1~exp1~20240619112324.785)

d /__w/pybind11/pybind11/build/tests && /usr/bin/c++ -DPYBIND11_ENABLE_TYPE_CASTER_ODR_GUARD_IF_AVAILABLE -DPYBIND11_TEST_EIGEN -Dpybind11_tests_EXPORTS -I/__w/pybind11/pybind11/include -isystem /usr/include/python3.11 -isystem /usr/include/eigen3 -Os -DNDEBUG -fPIC -fvisibility=hidden -Wall -Wextra -Wconversion -Wcast-qual -Wdeprecated -Wundef -Wnon-virtual-dtor -Werror -flto -std=c++11 -MD -MT tests/CMakeFiles/pybind11_tests.dir/pybind11_tests.cpp.o -MF CMakeFiles/pybind11_tests.dir/pybind11_tests.cpp.o.d -o CMakeFiles/pybind11_tests.dir/pybind11_tests.cpp.o -c /__w/pybind11/pybind11/tests/pybind11_tests.cpp
In file included from /__w/pybind11/pybind11/tests/pybind11_cross_module_tests.cpp:10:
In file included from /__w/pybind11/pybind11/include/pybind11/stl_bind.h:15:
In file included from /__w/pybind11/pybind11/include/pybind11/operators.h:12:
In file included from /__w/pybind11/pybind11/include/pybind11/pybind11.h:14:
/__w/pybind11/pybind11/include/pybind11/detail/init.h:221:53: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  221 |     auto smhldr = type_caster<Cpp<Class>>::template smart_holder_from_unique_ptr(
      |                                                     ^
/__w/pybind11/pybind11/include/pybind11/detail/init.h:2[36](https://github.com/pybind/pybind11/actions/runs/9586053423/job/26433234621?pr=5175#step:6:37):55: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  236 |     auto smhldr = type_caster<Alias<Class>>::template smart_holder_from_unique_ptr(
      |                                                       ^
/__w/pybind11/pybind11/include/pybind11/detail/init.h:253:53: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  253 |     auto smhldr = type_caster<Cpp<Class>>::template smart_holder_from_shared_ptr(shd_ptr);
      |                                                     ^
/__w/pybind11/pybind11/include/pybind11/detail/init.h:266:55: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  266 |     auto smhldr = type_caster<Alias<Class>>::template smart_holder_from_shared_ptr(shd_ptr);
      |                                                       ^
In file included from /__w/pybind11/pybind11/tests/pybind11_tests.cpp:10:
In file included from /__w/pybind11/pybind11/tests/pybind11_tests.h:3:
In file included from /__w/pybind11/pybind11/include/pybind11/eval.h:14:
In file included from /__w/pybind11/pybind11/include/pybind11/pybind11.h:14:
/__w/pybind11/pybind11/include/pybind11/detail/init.h:221:53: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  221 |     auto smhldr = type_caster<Cpp<Class>>::template smart_holder_from_unique_ptr(
      |                                                     ^
/__w/pybind11/pybind11/include/pybind11/detail/init.h:236:55: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  236 |     auto smhldr = type_caster<Alias<Class>>::template smart_holder_from_unique_ptr(
      |                                                       ^
/__w/pybind11/pybind11/include/pybind11/detail/init.h:2[53](https://github.com/pybind/pybind11/actions/runs/9586053423/job/26433234621?pr=5175#step:6:54):53: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  253 |     auto smhldr = type_caster<Cpp<Class>>::template smart_holder_from_shared_ptr(shd_ptr);
      |                                                     ^
/__w/pybind11/pybind11/include/pybind11/detail/init.h:266:[55](https://github.com/pybind/pybind11/actions/runs/9586053423/job/26433234621?pr=5175#step:6:56): error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
  266 |     auto smhldr = type_caster<Alias<Class>>::template smart_holder_from_shared_ptr(shd_ptr);
      |                                                       ^
4 errors generated.

rwgk · 2024-06-19T18:09:24Z

This is the calling code triggering the error:

pybind11/include/pybind11/detail/init.h

Lines 221 to 222 in b739a53

    
           auto smhldr = type_caster<Cpp<Class>>::template smart_holder_from_unique_ptr( 
        
               std::move(unq_ptr), /*void_cast_raw_ptr*/ Class::has_alias && is_alias<Class>(ptr));

This is the called code:

pybind11/include/pybind11/detail/smart_holder_type_casters.h

Lines 349 to 354 in b739a53

    
           template <typename T, typename D> 
        
           static smart_holder smart_holder_from_unique_ptr(std::unique_ptr<T, D> &&unq_ptr, 
        
                                                            bool void_cast_raw_ptr) { 
        
               void *void_ptr = void_cast_raw_ptr ? static_cast<void *>(unq_ptr.get()) : nullptr; 
        
               return pybindit::memory::smart_holder::from_unique_ptr(std::move(unq_ptr), void_ptr); 
        
           }

… dev errors (see pybind#5175).

… dev errors (see #5175). (#5176)

rwgk · 2024-06-19T21:09:34Z

clang 19.0.0 dev is correct. Long-standing misunderstanding of mine, resolved via #5176.

Dummy change.

dcf7f6b

rwgk mentioned this pull request Jun 19, 2024

[smart_holder] git merge master #5174

Merged

rwgk pushed a commit to rwgk/pybind11 that referenced this pull request Jun 19, 2024

Remove incorrectly placed template keywords to resolve clang 19.0.0…

a8aa88a

… dev errors (see pybind#5175).

rwgk mentioned this pull request Jun 19, 2024

[smart_holder] Remove incorrectly placed template keywords #5176

Merged

rwgk pushed a commit that referenced this pull request Jun 19, 2024

Remove incorrectly placed template keywords to resolve clang 19.0.0…

1cafcee

… dev errors (see #5175). (#5176)

rwgk closed this Jun 19, 2024

rwgk deleted the smart_holder_with_dummy_change branch June 19, 2024 21:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[smart_holder] Dummy change. Just to trigger CI. #5175

[smart_holder] Dummy change. Just to trigger CI. #5175

rwgk commented Jun 19, 2024 •

edited

Loading

rwgk commented Jun 19, 2024

rwgk commented Jun 19, 2024

rwgk commented Jun 19, 2024

rwgk commented Jun 19, 2024

[smart_holder] Dummy change. Just to trigger CI. #5175

[smart_holder] Dummy change. Just to trigger CI. #5175

Conversation

rwgk commented Jun 19, 2024 • edited Loading

Description

Suggested changelog entry:

rwgk commented Jun 19, 2024

rwgk commented Jun 19, 2024

rwgk commented Jun 19, 2024

rwgk commented Jun 19, 2024

rwgk commented Jun 19, 2024 •

edited

Loading